Commit 7b7590f8 authored by Vitaliy Mysak's avatar Vitaliy Mysak Committed by Ben Walker
Browse files

ocf: Improve handling of partial IOs 



Improve handling of partial IOs for case when iovcnt == 1.
This case is pretty frqeuent because all data allocated by OCF
  have iovcnt == 1 (see ctx->data->alloc() or vbdev_ocf_ctx_data_alloc())

Change-Id: I8d38ca9e9d2bd3e6ce298bf788ce6ed782b56594
Signed-off-by: default avatarVitaliy Mysak <vitaliy.mysak@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/456202


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent 2bfa860d

lib/bdev/ocf/volume.c

+34 −20
Original line number Diff line number Diff line
@@ -303,6 +303,18 @@ vbdev_ocf_volume_submit_io(struct ocf_io *io) 
	offset = io_ctx->offset;



	if (len < io_ctx->data->size) {

		if (io_ctx->data->iovcnt == 1) {

			if (io->dir == OCF_READ) {

				status = spdk_bdev_read(base->desc, io_ctx->ch,

							io_ctx->data->iovs[0].iov_base + offset, addr, len,

							vbdev_ocf_volume_submit_io_cb, io);

			} else if (io->dir == OCF_WRITE) {

				status = spdk_bdev_write(base->desc, io_ctx->ch,

							 io_ctx->data->iovs[0].iov_base + offset, addr, len,

							 vbdev_ocf_volume_submit_io_cb, io);

			}

			goto end;

		} else {

			i = get_starting_vec(io_ctx->data->iovs, io_ctx->data->iovcnt, &offset);



			if (i < 0) {
@@ -324,6 +336,7 @@ vbdev_ocf_volume_submit_io(struct ocf_io *io) 


			initialize_cpy_vector(iovs, io_ctx->data->iovcnt, &io_ctx->data->iovs[i],

					      iovcnt, offset, len);

		}

	} else {

		iovs = io_ctx->data->iovs;

		iovcnt = io_ctx->data->iovcnt;
@@ -337,6 +350,7 @@ vbdev_ocf_volume_submit_io(struct ocf_io *io) 
					  iovs, iovcnt, addr, len, vbdev_ocf_volume_submit_io_cb, io);

	}



end:

	if (status) {

		/* TODO [ENOMEM]: implement ENOMEM handling when submitting IO to base device */