Commit 7b3f4110 authored by Darek Stojaczyk's avatar Darek Stojaczyk Committed by Jim Harris
Browse files

thread: fix deadlock in spdk_for_each_thread error handling 



We could return from spdk_for_each_thread() without
unlocking the global threading mutex, rendering the
entire SPDK application useless.

Change-Id: I641c7b36db996f9a36310332279648014579de83
Signed-off-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/452087


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 0dcc5077

lib/thread/thread.c

+2 −1
Original line number Diff line number Diff line
@@ -786,7 +786,6 @@ spdk_for_each_thread(spdk_msg_fn fn, void *ctx, spdk_msg_fn cpl) 
	ct->ctx = ctx;

	ct->cpl = cpl;



	pthread_mutex_lock(&g_devlist_mutex);

	thread = _get_thread();

	if (!thread) {

		SPDK_ERRLOG("No thread allocated\n");
@@ -795,6 +794,8 @@ spdk_for_each_thread(spdk_msg_fn fn, void *ctx, spdk_msg_fn cpl) 
		return;

	}

	ct->orig_thread = thread;



	pthread_mutex_lock(&g_devlist_mutex);

	ct->cur_thread = TAILQ_FIRST(&g_threads);

	pthread_mutex_unlock(&g_devlist_mutex);