Commit 7b05b29d authored by Jim Harris's avatar Jim Harris Committed by Tomasz Zawadzki
Browse files

nvme/pcie: use 4-byte trace arguments where possible 



Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: I24c3fd545cadc403ac1f3589c6242a08a7a2f517
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14000


Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJacek Kalwas <jacek.kalwas@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
parent cdb0726b

lib/nvme/nvme_pcie_common.c

+10 −8
Original line number Diff line number Diff line
@@ -630,7 +630,8 @@ nvme_pcie_qpair_submit_tracker(struct spdk_nvme_qpair *qpair, struct nvme_tracke 
	assert(req != NULL);



	spdk_trace_record(TRACE_NVME_PCIE_SUBMIT, qpair->id, 0, (uintptr_t)req,

			  req->cmd.cid, req->cmd.opc, req->cmd.cdw10, req->cmd.cdw11, req->cmd.cdw12);

			  (uint32_t)req->cmd.cid, (uint32_t)req->cmd.opc,

			  req->cmd.cdw10, req->cmd.cdw11, req->cmd.cdw12);



	if (req->cmd.fuse) {

		/*
@@ -675,7 +676,8 @@ nvme_pcie_qpair_complete_tracker(struct spdk_nvme_qpair *qpair, struct nvme_trac 


	req = tr->req;



	spdk_trace_record(TRACE_NVME_PCIE_COMPLETE, qpair->id, 0, (uintptr_t)req, req->cmd.cid);

	spdk_trace_record(TRACE_NVME_PCIE_COMPLETE, qpair->id, 0, (uintptr_t)req,

			  (uint32_t)req->cmd.cid);



	assert(req != NULL);
@@ -1816,17 +1818,17 @@ SPDK_TRACE_REGISTER_FN(nvme_pcie, "nvme_pcie", TRACE_GROUP_NVME_PCIE) 
		{

			"NVME_PCIE_SUBMIT", TRACE_NVME_PCIE_SUBMIT,

			OWNER_NVME_PCIE_QP, OBJECT_NVME_PCIE_TR, 1,

			{	{ "cid", SPDK_TRACE_ARG_TYPE_INT, 8 },

				{ "opc", SPDK_TRACE_ARG_TYPE_INT, 8 },

				{ "dw10", SPDK_TRACE_ARG_TYPE_PTR, 8 },

				{ "dw11", SPDK_TRACE_ARG_TYPE_PTR, 8 },

				{ "dw12", SPDK_TRACE_ARG_TYPE_PTR, 8 }

			{	{ "cid", SPDK_TRACE_ARG_TYPE_INT, 4 },

				{ "opc", SPDK_TRACE_ARG_TYPE_INT, 4 },

				{ "dw10", SPDK_TRACE_ARG_TYPE_PTR, 4 },

				{ "dw11", SPDK_TRACE_ARG_TYPE_PTR, 4 },

				{ "dw12", SPDK_TRACE_ARG_TYPE_PTR, 4 }

			}

		},

		{

			"NVME_PCIE_COMPLETE", TRACE_NVME_PCIE_COMPLETE,

			OWNER_NVME_PCIE_QP, OBJECT_NVME_PCIE_TR, 0,

			{{ "cid", SPDK_TRACE_ARG_TYPE_INT, 8 }}

			{{ "cid", SPDK_TRACE_ARG_TYPE_INT, 4 }}

		},

	};