Commit 7aa92ad5 authored by wanghailiangx's avatar wanghailiangx Committed by Jim Harris
Browse files

bdev module: remove support for deprecated RPC names 



These were deprecated in 2019, it's time to remove
support for them now.

Change-Id: I9e203a52877802127df8144e68090d7975f9d200
Signed-off-by: default avatarwanghailiangx <hailiangx.e.wang@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12772


Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 13067997

doc/bdev.md

+1 −1
Original line number Diff line number Diff line
@@ -120,7 +120,7 @@ a value of 1 tells the driver to use QAT and if not available then the creation 
the vbdev should fail to create or load.  A value of '2' as shown below tells the module

to use ISAL and if for some reason it is not available, the vbdev should fail to create or load.



`rpc.py compress_set_pmd -p 2`

`rpc.py bdev_compress_set_pmd -p 2`



To remove a compression vbdev, use the following command which will also delete the PMEM

file.  If the logical volume is deleted the PMEM file will not be removed and the

module/bdev/aio/bdev_aio_rpc.c

+0 −2
Original line number Diff line number Diff line
@@ -109,7 +109,6 @@ rpc_bdev_aio_create(struct spdk_jsonrpc_request *request, 
	spdk_bdev_wait_for_examine(rpc_bdev_aio_create_cb, ctx);

}

SPDK_RPC_REGISTER("bdev_aio_create", rpc_bdev_aio_create, SPDK_RPC_RUNTIME)

SPDK_RPC_REGISTER_ALIAS_DEPRECATED(bdev_aio_create, construct_aio_bdev)



struct rpc_rescan_aio {

	char *name;
@@ -188,4 +187,3 @@ cleanup: 
	free_rpc_delete_aio(&req);

}

SPDK_RPC_REGISTER("bdev_aio_delete", rpc_bdev_aio_delete, SPDK_RPC_RUNTIME)
 
SPDK_RPC_REGISTER_ALIAS_DEPRECATED(bdev_aio_delete, delete_aio_bdev)

module/bdev/compress/vbdev_compress_rpc.c

+0 −4
Original line number Diff line number Diff line
@@ -138,8 +138,6 @@ rpc_bdev_compress_set_pmd(struct spdk_jsonrpc_request *request, 
}

SPDK_RPC_REGISTER("bdev_compress_set_pmd", rpc_bdev_compress_set_pmd,

		  SPDK_RPC_STARTUP | SPDK_RPC_RUNTIME)

SPDK_RPC_REGISTER_ALIAS_DEPRECATED(bdev_compress_set_pmd, set_compress_pmd)

SPDK_RPC_REGISTER_ALIAS_DEPRECATED(bdev_compress_set_pmd, compress_set_pmd)



/* Structure to hold the parameters for this RPC method. */

struct rpc_construct_compress {
@@ -204,7 +202,6 @@ cleanup: 
	free_rpc_construct_compress(&req);

}

SPDK_RPC_REGISTER("bdev_compress_create", rpc_bdev_compress_create, SPDK_RPC_RUNTIME)

SPDK_RPC_REGISTER_ALIAS_DEPRECATED(bdev_compress_create, construct_compress_bdev)



struct rpc_delete_compress {

	char *name;
@@ -246,4 +243,3 @@ rpc_bdev_compress_delete(struct spdk_jsonrpc_request *request, 
	free_rpc_delete_compress(&req);

}

SPDK_RPC_REGISTER("bdev_compress_delete", rpc_bdev_compress_delete, SPDK_RPC_RUNTIME)
 
SPDK_RPC_REGISTER_ALIAS_DEPRECATED(bdev_compress_delete, delete_compress_bdev)

module/bdev/crypto/vbdev_crypto_rpc.c

+0 −2
Original line number Diff line number Diff line
@@ -288,7 +288,6 @@ cleanup: 
	free_rpc_construct_crypto(&req);

}

SPDK_RPC_REGISTER("bdev_crypto_create", rpc_bdev_crypto_create, SPDK_RPC_RUNTIME)

SPDK_RPC_REGISTER_ALIAS_DEPRECATED(bdev_crypto_create, construct_crypto_bdev)



struct rpc_delete_crypto {

	char *name;
@@ -340,4 +339,3 @@ cleanup: 
	free_rpc_delete_crypto(&req);

}

SPDK_RPC_REGISTER("bdev_crypto_delete", rpc_bdev_crypto_delete, SPDK_RPC_RUNTIME)
 
SPDK_RPC_REGISTER_ALIAS_DEPRECATED(bdev_crypto_delete, delete_crypto_bdev)

module/bdev/error/vbdev_error_rpc.c

+0 −3
Original line number Diff line number Diff line
@@ -114,7 +114,6 @@ cleanup: 
	free_rpc_bdev_error_create(&req);

}

SPDK_RPC_REGISTER("bdev_error_create", rpc_bdev_error_create, SPDK_RPC_RUNTIME)

SPDK_RPC_REGISTER_ALIAS_DEPRECATED(bdev_error_create, construct_error_bdev)



struct rpc_delete_error {

	char *name;
@@ -162,7 +161,6 @@ cleanup: 
	free_rpc_delete_error(&req);

}

SPDK_RPC_REGISTER("bdev_error_delete", rpc_bdev_error_delete, SPDK_RPC_RUNTIME)

SPDK_RPC_REGISTER_ALIAS_DEPRECATED(bdev_error_delete, delete_error_bdev)



struct rpc_error_information {

	char *name;
@@ -230,4 +228,3 @@ cleanup: 
	free_rpc_error_information(&req);

}

SPDK_RPC_REGISTER("bdev_error_inject_error", rpc_bdev_error_inject_error, SPDK_RPC_RUNTIME)
 
SPDK_RPC_REGISTER_ALIAS_DEPRECATED(bdev_error_inject_error, bdev_inject_error)