Commit 7aa53faa authored by Daniel Verkamp's avatar Daniel Verkamp Committed by Jim Harris
Browse files

bdev/virtio: remove __rte_unused annotations 



These are just noise, since we don't enable the unused parameter
warning.

Also remove an unused variable, txvq, in virtio_dev_start() that
had been left behind since it was marked as __rte_unused.

Change-Id: I7bda85ef5f2208dd36d8f1806d8241a04b893123
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/382494


Reviewed-by: default avatarDariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
parent c32510da

lib/bdev/virtio/rte_virtio/virtio_dev.c

+0 −2
Original line number Diff line number Diff line
@@ -307,8 +307,6 @@ virtio_dev_free(struct virtio_dev *dev) 
int

virtio_dev_start(struct virtio_dev *vdev)

{

	struct virtnet_tx *txvq __rte_unused;



	/* Enable uio/vfio intr/eventfd mapping: althrough we already did that

	 * in device configure, but it could be unmapped  when device is

	 * stopped.

lib/bdev/virtio/rte_virtio/virtio_pci.c

+1 −1
Original line number Diff line number Diff line
@@ -445,7 +445,7 @@ modern_del_queue(struct virtio_dev *dev, struct virtqueue *vq) 
}



static void

modern_notify_queue(struct virtio_dev *dev __rte_unused, struct virtqueue *vq)

modern_notify_queue(struct virtio_dev *dev, struct virtqueue *vq)

{

	spdk_mmio_write_2(vq->notify_addr, vq->vq_queue_index);

}

lib/bdev/virtio/rte_virtio/virtio_user.c

+6 −6
Original line number Diff line number Diff line
@@ -122,7 +122,7 @@ virtio_user_set_features(struct virtio_dev *vdev, uint64_t features) 
}



static uint8_t

virtio_user_get_isr(struct virtio_dev *vdev __rte_unused)

virtio_user_get_isr(struct virtio_dev *vdev)

{

	/* rxq interrupts and config interrupt are separated in virtio-user,

	 * here we only report config change.
@@ -131,15 +131,15 @@ virtio_user_get_isr(struct virtio_dev *vdev __rte_unused) 
}



static uint16_t

virtio_user_set_config_irq(struct virtio_dev *vdev __rte_unused,

		    uint16_t vec __rte_unused)

virtio_user_set_config_irq(struct virtio_dev *vdev,

			   uint16_t vec)

{

	return 0;

}



static uint16_t

virtio_user_set_queue_irq(struct virtio_dev *vdev __rte_unused,

			  struct virtqueue *vq __rte_unused,

virtio_user_set_queue_irq(struct virtio_dev *vdev,

			  struct virtqueue *vq,

			  uint16_t vec)

{

	/* pretend we have done that */
@@ -151,7 +151,7 @@ virtio_user_set_queue_irq(struct virtio_dev *vdev __rte_unused, 
 * max supported queues.

 */

static uint16_t

virtio_user_get_queue_num(struct virtio_dev *vdev, uint16_t queue_id __rte_unused)

virtio_user_get_queue_num(struct virtio_dev *vdev, uint16_t queue_id)

{

	struct virtio_user_dev *dev = virtio_dev_get_user_dev(vdev);