Commit 785e7fc3 authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Jim Harris
Browse files

iscsi: Remove unnecessary mutex to read a variable for CHAP authentication 



Remove mutex to guard discovery_auth_group in
spdk_iscsi_get_authinfo() because update of discovery_auth_group
is atomic even no mutex.

Change-Id: Id9ddcb84c2fc3c820984e52dda7ca73839497e24
Signed-off-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/422765


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent 83d439f1

lib/iscsi/iscsi.c

+0 −2
Original line number Diff line number Diff line
@@ -689,9 +689,7 @@ spdk_iscsi_get_authinfo(struct spdk_iscsi_conn *conn, const char *authuser) 
		ag_tag = -1;

	}

	if (ag_tag < 0) {

		pthread_mutex_lock(&g_spdk_iscsi.mutex);

		ag_tag = g_spdk_iscsi.chap_group;

		pthread_mutex_unlock(&g_spdk_iscsi.mutex);

	}

	SPDK_DEBUGLOG(SPDK_LOG_ISCSI, "ag_tag=%d\n", ag_tag);