Commit 780cb81f authored by Jim Harris's avatar Jim Harris Committed by Tomasz Zawadzki
Browse files

nbd: remove unnecessary TAILQ_EMPTY checks 



In a few places we first check TAILQ_EMPTY, and then do a TAILQ_FOREACH
operation. But the former is not necessary, TAILQ_FOREACH on an empty TAILQ
will just be nop anyways.

Signed-off-by: default avatarJim Harris <jim.harris@samsung.com>
Change-Id: Ie1c50345392cfd7bfe70ca6928b99594a07b80fa
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21373


Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarMateusz Kozlowski <mateusz.kozlowski@solidigm.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 90481da6

lib/nbd/nbd.c

+13 −19
Original line number Diff line number Diff line
@@ -540,7 +540,6 @@ nbd_io_exec(struct spdk_nbd_disk *nbd) 
	int io_count = 0;

	int ret = 0;



	if (!TAILQ_EMPTY(&nbd->received_io_list)) {

	TAILQ_FOREACH_SAFE(io, &nbd->received_io_list, tailq, io_tmp) {

		TAILQ_REMOVE(&nbd->received_io_list, io, tailq);

		TAILQ_INSERT_TAIL(&nbd->processing_io_list, io, tailq);
@@ -551,7 +550,6 @@ nbd_io_exec(struct spdk_nbd_disk *nbd) 


		io_count++;

	}

	}



	return io_count;

}
@@ -861,18 +859,14 @@ nbd_bdev_hot_remove(struct spdk_nbd_disk *nbd) 
	nbd->is_closing = true;

	nbd_cleanup_io(nbd);



	if (!TAILQ_EMPTY(&nbd->received_io_list)) {

	TAILQ_FOREACH_SAFE(io, &nbd->received_io_list, tailq, io_tmp) {

		TAILQ_REMOVE(&nbd->received_io_list, io, tailq);

		TAILQ_INSERT_TAIL(&nbd->processing_io_list, io, tailq);

	}

	}

	if (!TAILQ_EMPTY(&nbd->processing_io_list)) {

	TAILQ_FOREACH_SAFE(io, &nbd->processing_io_list, tailq, io_tmp) {

		nbd_io_done(NULL, false, io);

	}

}

}



static void

nbd_bdev_event_cb(enum spdk_bdev_event_type type, struct spdk_bdev *bdev,