Commit 7791acfe authored May 15, 2025 by Aleksey Marchuk Committed by Jim Harris May 15, 2025

lib/nvme_util: Fix compilation error



Variable declaration is not allowed in case statement
without wrapping it in a block.
GCC 9.4.0 throws the following warning:

nvme_util.c: In function ‘spdk_nvme_build_name’:
nvme_util.c:144:3: error: a label can only be part of a statement and a declaration is not a statement
       |   struct spdk_pci_device *dev;
       |   ^~~~~~

Change-Id: I35c7d2a2fadf4a440b2856ff1f1b59d74bac2797
Signed-off-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/25927


Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Tomasz Zawadzki <tomasz@tzawadzki.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK Automated Test System <spdkbot@gmail.com>
Reviewed-by: Jacek Kalwas <jacek.kalwas@nutanix.com>
Reviewed-by: Konrad Sztyber <ksztyber@nvidia.com>

parent 0c9e106c

lib/nvme/nvme_util.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -140,7 +140,7 @@ spdk_nvme_build_name(char name, size_t length, struct spdk_nvme_ctrlr ctrlr,
		trid = spdk_nvme_ctrlr_get_transport_id(ctrlr);

		switch (trid->trtype) {
		case SPDK_NVME_TRANSPORT_PCIE:
		case SPDK_NVME_TRANSPORT_PCIE: {
		struct spdk_pci_device *dev;

		res = snprintf(name, length, "PCIE (%s)", trid->traddr);
		@@ -156,8 +156,8 @@ spdk_nvme_build_name(char name, size_t length, struct spdk_nvme_ctrlr ctrlr,
		res = res + _res;
		}
		}

		break;
		}
		case SPDK_NVME_TRANSPORT_RDMA:
		res = snprintf(name, length, "RDMA (addr:%s subnqn:%s)", trid->traddr, trid->subnqn);
		break;