+1
−8
Loading
Before removing the DPDK dependency from the iSCSI connection load balancing, this should be done. In spdk_iscsi_conn_allocate_reactor(cpumask) - if any lcore[i]'s state is FINISHED, the caller calls rte_eal_wait_lcore(i). But the purpose of rte_eal_wait_lcore() is to check if the slave is in a WAIT state before calling rte_eal_remote_launch(). The meaning of this usage is not clear. - If the state of lcore[i] is WAIT or FINISHED, the reactor does not run on the lcore[i]. iSCSI connections consist of not reactor but poller. Hence selecting lcore[i] with the state WAIT or FINISHED does not look correct. Change-Id: If8c420f2d16dc44e77f8963f5732faa52e3d829b Signed-off-by:Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/391332 Reviewed-by:
Jim Harris <james.r.harris@intel.com> Reviewed-by:
Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by:
Ben Walker <benjamin.walker@intel.com> Tested-by:
SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by:
Ziye Yang <optimistyzy@gmail.com>