Commit 766afaaa authored by Daniel Verkamp's avatar Daniel Verkamp Committed by Gerrit Code Review
Browse files

nvme/test: avoid clang warnings in nvme_ns_cmd_ut 



Initialize the full nvme_namespace structure in prepare_for_test() so
that e.g. ns->id is not used uninitialized.

Also check for request allocation failure - if the request is NULL, we
can't run the rest of the tests that dereference request without
crashing.

Change-Id: I3010ca3e81f153a4d0201498a14a963c2b9e960d
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
parent 4ac57251

test/lib/nvme/unit/nvme_ns_cmd_c/nvme_ns_cmd_ut.c

+9 −1
Original line number Diff line number Diff line
@@ -94,6 +94,7 @@ prepare_for_test(struct nvme_namespace *ns, struct nvme_controller *ctrlr, 
		 uint32_t stripe_size)

{

	ctrlr->max_xfer_size = max_xfer_size;

	memset(ns, 0, sizeof(*ns));

	ns->ctrlr = ctrlr;

	ns->sector_size = sector_size;

	ns->stripe_size = stripe_size;
@@ -122,8 +123,11 @@ split_test(void) 


	CU_ASSERT(rc == 0);

	CU_ASSERT(g_request != NULL);

	CU_ASSERT(g_request->num_children == 0);

	if (g_request == NULL) {

		return; /* can't run the rest of the tests without crashing if this failed */

	}



	CU_ASSERT(g_request->num_children == 0);

	nvme_free_request(g_request);

}
@@ -147,6 +151,10 @@ split_test2(void) 


	CU_ASSERT(rc == 0);

	CU_ASSERT(g_request != NULL);

	if (g_request == NULL) {

		return; /* can't run the rest of the tests without crashing if this failed */

	}



	CU_ASSERT(g_request->num_children == 2);



	child = TAILQ_FIRST(&g_request->children);