Commit 760bb7e8 authored by Jim Harris's avatar Jim Harris
Browse files

check_format.sh: skip coding style checks if astyle is too old 



check_format.sh isn't really function when astyle is too old - it
reports a bunch of style errors that don't really exist.  So just
skip running astyle in these cases.

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: Ifee769a296791d11b1ec693d398922e87d76bb69

Reviewed-on: https://review.gerrithub.io/435960


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent 6c8af3ef

scripts/check_format.sh

+23 −22
Original line number Diff line number Diff line
@@ -63,8 +63,8 @@ if hash astyle; then 
	echo -n "Checking coding style..."

	if [ "$(astyle -V)" \< "Artistic Style Version 3" ]

	then

		echo -n " Your astyle version is too old. This may cause failure on patch verification performed by CI. Please update astyle to at least 3.0.1 version..."

	fi

		echo -n " Your astyle version is too old so skipping coding style checks. Please update astyle to at least 3.0.1 version..."

	else

		rm -f astyle.log

		touch astyle.log

		# Exclude rte_vhost code imported from DPDK - we want to keep the original code
@@ -87,6 +87,7 @@ if hash astyle; then 
			echo " OK"

		fi

		rm -f astyle.log

	fi

else

	echo "You do not have astyle installed so your code style is not being checked!"

fi