Commit 75a6265d authored by Darek Stojaczyk's avatar Darek Stojaczyk
Browse files

rpc: fix segfault on get_spdk_version request with extra params 



We tried to send two responses for a single RPC request.

Fixes #798

Change-Id: I37eebd6a1212f6ab2c026b7587415e42c3c7417e
Signed-off-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/455220


Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent e036215f

lib/rpc/rpc.c

+1 −0
Original line number Diff line number Diff line
@@ -391,6 +391,7 @@ spdk_rpc_get_spdk_version(struct spdk_jsonrpc_request *request, const struct spd 
	if (params != NULL) {

		spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,

						 "get_spdk_version method requires no parameters");

		return;

	}



	w = spdk_jsonrpc_begin_result(request);