Commit 75711828 authored by Karol Latecki's avatar Karol Latecki Committed by Darek Stojaczyk
Browse files

bdev/lvol: remove if checks for obligatory rpc arguments 



These arguments are obligatory and spdk_json_decode_object will
fail even before we reach the if block.

Change-Id: I295649629770ef062086308257da83a8bab44588
Signed-off-by: default avatarKarol Latecki <karol.latecki@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/461860


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent a755fb5f

lib/bdev/lvol/vbdev_lvol_rpc.c

+0 −17
Original line number Diff line number Diff line
@@ -136,17 +136,6 @@ spdk_rpc_construct_lvol_store(struct spdk_jsonrpc_request *request, 
		goto invalid;

	}



	if (req.bdev_name == NULL) {

		SPDK_ERRLOG("missing bdev_name param\n");

		rc = -EINVAL;

		goto invalid;

	}



	if (req.lvs_name == NULL) {

		SPDK_ERRLOG("missing lvs_name param\n");

		rc = -EINVAL;

		goto invalid;

	}

	bdev = spdk_bdev_get_by_name(req.bdev_name);

	if (bdev == NULL) {

		SPDK_ERRLOG("bdev '%s' does not exist\n", req.bdev_name);
@@ -894,12 +883,6 @@ spdk_rpc_resize_lvol_bdev(struct spdk_jsonrpc_request *request, 
		goto invalid;

	}



	if (req.name == NULL) {

		SPDK_ERRLOG("missing name param\n");

		rc = -EINVAL;

		goto invalid;

	}



	bdev = spdk_bdev_get_by_name(req.name);

	if (bdev == NULL) {

		SPDK_ERRLOG("no bdev for provided name %s\n", req.name);