Commit 7538af70 authored by Maciej Wawryk's avatar Maciej Wawryk Committed by Jim Harris
Browse files

RPC: rename nvmf_subsystem_create to nvmf_create_subsystem 



Signed-off-by: default avatarMaciej Wawryk <maciejx.wawryk@intel.com>
Change-Id: Ic3aa9f168b2e612e461c450ef1e5e1ae81fa5635
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/468963


Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 80a0c5be

doc/jsonrpc.md

+2 −2
Original line number Diff line number Diff line
@@ -3836,7 +3836,7 @@ Example response: 
}

~~~



## nvmf_subsystem_create method {#rpc_nvmf_subsystem_create}

## nvmf_create_subsystem method {#rpc_nvmf_create_subsystem}



Construct an NVMe over Fabrics target subsystem.
@@ -3859,7 +3859,7 @@ Example request: 
{

  "jsonrpc": "2.0",

  "id": 1,

  "method": "nvmf_subsystem_create",

  "method": "nvmf_create_subsystem",

  "params": {

    "nqn": "nqn.2016-06.io.spdk:cnode1",

    "allow_any_host": false,

doc/nvmf.md

+1 −1
Original line number Diff line number Diff line
@@ -171,7 +171,7 @@ NQN, serial number, and IP address with RDMA transport to your own circumstances 


~~~{.sh}

scripts/rpc.py bdev_malloc_create -b Malloc0 512 512

scripts/rpc.py nvmf_subsystem_create nqn.2016-06.io.spdk:cnode1 -a -s SPDK00000000000001 -d SPDK_Controller1

scripts/rpc.py nvmf_create_subsystem nqn.2016-06.io.spdk:cnode1 -a -s SPDK00000000000001 -d SPDK_Controller1

scripts/rpc.py nvmf_subsystem_add_ns nqn.2016-06.io.spdk:cnode1 Malloc0

scripts/rpc.py nvmf_subsystem_add_listener nqn.2016-06.io.spdk:cnode1 -t rdma -a 192.168.100.8 -s 4420

~~~

lib/nvmf/nvmf.c

+1 −1
Original line number Diff line number Diff line
@@ -380,7 +380,7 @@ spdk_nvmf_write_subsystem_config_json(struct spdk_json_write_ctx *w, 


	/* { */

	spdk_json_write_object_begin(w);

	spdk_json_write_named_string(w, "method", "nvmf_subsystem_create");

	spdk_json_write_named_string(w, "method", "nvmf_create_subsystem");



	/*     "params" : { */

	spdk_json_write_named_object_begin(w, "params");

lib/nvmf/nvmf_rpc.c

+3 −2
Original line number Diff line number Diff line
@@ -370,7 +370,7 @@ spdk_rpc_nvmf_subsystem_started(struct spdk_nvmf_subsystem *subsystem, 
}



static void

spdk_rpc_nvmf_subsystem_create(struct spdk_jsonrpc_request *request,

spdk_rpc_nvmf_create_subsystem(struct spdk_jsonrpc_request *request,

			       const struct spdk_json_val *params)

{

	struct rpc_subsystem_create *req;
@@ -441,7 +441,8 @@ invalid_custom_response: 
	}

	free(req);

}

SPDK_RPC_REGISTER("nvmf_subsystem_create", spdk_rpc_nvmf_subsystem_create, SPDK_RPC_RUNTIME)

SPDK_RPC_REGISTER("nvmf_create_subsystem", spdk_rpc_nvmf_create_subsystem, SPDK_RPC_RUNTIME)

SPDK_RPC_REGISTER_ALIAS_DEPRECATED(nvmf_create_subsystem, nvmf_subsystem_create)



struct rpc_delete_subsystem {

	char *nqn;

scripts/config_converter.py

+2 −2
Original line number Diff line number Diff line
@@ -355,11 +355,11 @@ def get_nvmf_subsystem_json(config, section): 
                    "bdev_name": items[0],

                })

    # Get parameters: nqn, allow_any_host, serial_number

    # for nvmf_subsystem_create rpc method

    # for nvmf_create_subsystem rpc method

    parameters = to_json_params(params[1:5])

    nvmf_subsystem_methods.append({

        "params": parameters,

        "method": "nvmf_subsystem_create"

        "method": "nvmf_create_subsystem"

    })

    for listen in listen_address:

        nvmf_subsystem_methods.append({