Commit 74efab1e authored by Michal Berger's avatar Michal Berger Committed by Konrad Sztyber
Browse files

doc: Don't include spdk.common.mk 



It does not seem to be needed as the only thing it provides is the "@"
prefix - this isn't really relevant unless we run our test where we
parse output to see if there were any issues with doxygen. Other
than that, it only enforces user to run ./configure, which adds extra
~20s on top where the actual doc build takes ~5s.

Change-Id: I2c85b9e9552aec463a142a4c0947b0cab2cdda5c
Signed-off-by: default avatarMichal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18080


Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
parent 96e86305

doc/Makefile

+0 −3
Original line number Diff line number Diff line
@@ -3,9 +3,6 @@ 
#  All rights reserved.

#



SPDK_ROOT_DIR := $(abspath $(CURDIR)/..)

include $(SPDK_ROOT_DIR)/mk/spdk.common.mk



all: doc

	@:

test/common/autobuild_common.sh

+1 −2
Original line number Diff line number Diff line
@@ -321,7 +321,7 @@ _build_doc() { 
	local doxygenv

	doxygenv=$(doxygen --version)



	$MAKE -C "$rootdir"/doc --no-print-directory $MAKEFLAGS &> "$out"/doxygen.log

	$MAKE -C "$rootdir"/doc --no-print-directory $MAKEFLAGS Q=@ &> "$out"/doxygen.log

	if [ -s "$out"/doxygen.log ]; then

		if [[ "$doxygenv" == "1.8.20" ]]; then

			# Doxygen 1.8.20 produces false positives, see:
@@ -380,7 +380,6 @@ build_files() { 
}



build_doc() {

	"$rootdir/configure" $config_params --without-shared

	run_test "autobuild_build_doc" _build_doc

}