Commit 745a54e4 authored by Ben Walker's avatar Ben Walker Committed by Jim Harris
Browse files

nvmf/rdma: Handle successful requests on an errored queue pair 



Due to polling order, a request may have completed its previous
operation successfully, but the queue pair may be in an error
state. In this case, move the request directly to the
completed state to release resources.

Change-Id: Ic0a5ba036af246b1b6155169cf9682e943b73120
Signed-off-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.gerrithub.io/423412


Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarSeth Howell <seth.howell5141@gmail.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 194ba583

lib/nvmf/rdma.c

+6 −0
Original line number Diff line number Diff line
@@ -1243,6 +1243,12 @@ spdk_nvmf_rdma_request_process(struct spdk_nvmf_rdma_transport *rtransport, 


	assert(rdma_req->state != RDMA_REQUEST_STATE_FREE);



	/* If the queue pair is in an error state, force the request to the completed state

	 * to release resources. */

	if (rqpair->ibv_attr.qp_state == IBV_QPS_ERR) {

		rdma_req->state = RDMA_REQUEST_STATE_COMPLETED;

	}



	/* The loop here is to allow for several back-to-back state changes. */

	do {

		prev_state = rdma_req->state;