Commit 736e1c1b authored by Jim Harris's avatar Jim Harris
Browse files

test/unit/nvmf: fix qid too large test 



We need to be checking whether the specified qid
is too large or not - the current test says it is
doing that in the comments but is really just
checking the duplicate QID path (which following
test already covers).

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: I21dac3c7ec83a5c8e31fac77481708d54cb40e9e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17368


Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 3741a852

test/unit/lib/nvmf/ctrlr.c/ctrlr_ut.c

+2 −7
Original line number Diff line number Diff line
@@ -792,11 +792,9 @@ test_connect(void) 
	CU_ASSERT(sgroups[subsystem.id].mgmt_io_outstanding == 0);

	ctrlr.vcprop.cc.bits.iocqes = 4;



	/* I/O connect with too many existing qpairs */

	/* I/O connect with qid that is too large */

	memset(&rsp, 0, sizeof(rsp));

	spdk_bit_array_set(ctrlr.qpair_mask, 0);

	spdk_bit_array_set(ctrlr.qpair_mask, 1);

	spdk_bit_array_set(ctrlr.qpair_mask, 2);

	cmd.connect_cmd.qid = 3;

	sgroups[subsystem.id].mgmt_io_outstanding++;

	TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);

	rc = nvmf_ctrlr_cmd_connect(&req);
@@ -806,9 +804,6 @@ test_connect(void) 
	CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_QUEUE_IDENTIFIER);

	CU_ASSERT(qpair.ctrlr == NULL);

	CU_ASSERT(sgroups[subsystem.id].mgmt_io_outstanding == 0);

	spdk_bit_array_clear(ctrlr.qpair_mask, 0);

	spdk_bit_array_clear(ctrlr.qpair_mask, 1);

	spdk_bit_array_clear(ctrlr.qpair_mask, 2);



	/* I/O connect with duplicate queue ID */

	memset(&rsp, 0, sizeof(rsp));