Commit 730a63d0 authored by Daniel Verkamp's avatar Daniel Verkamp Committed by Ben Walker
Browse files

scsi: remove unreachable read iovec copy path 



The SCSI layer always passes task->iovs to spdk_bdev_readv(), so there
is no way for task->iovs != bdev_io->u.read.iovs to be true.

Change-Id: I4c0a2075c6e50e4304d62707a29bededa37b4e5c
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
parent 15fcb102

lib/scsi/scsi_bdev.c

+0 −9
Original line number Diff line number Diff line
@@ -1231,8 +1231,6 @@ spdk_bdev_scsi_task_complete(struct spdk_bdev_io *bdev_io, enum spdk_bdev_io_sta 
			     void *cb_arg)

{

	struct spdk_scsi_task		*task = cb_arg;

	struct iovec			*iovs;

	int				iovcnt;



	if (task->type == SPDK_SCSI_TASK_TYPE_CMD) {

		int sc, sk, asc, ascq;
@@ -1244,13 +1242,6 @@ spdk_bdev_scsi_task_complete(struct spdk_bdev_io *bdev_io, enum spdk_bdev_io_sta 
			task->response = SPDK_SCSI_TASK_MGMT_RESP_SUCCESS;

	}



	spdk_bdev_io_get_iovec(bdev_io, &iovs, &iovcnt);

	if (task->dxfer_dir == SPDK_SCSI_DIR_FROM_DEV && task->iovs != iovs) {

		assert(iovs != NULL);

		assert(task->iovcnt == iovcnt);

		memcpy(task->iovs, iovs, sizeof(task->iovs[0]) * task->iovcnt);

	}



	spdk_scsi_lun_complete_task(task->lun, task);

}