Commit 72a6cd53 authored by Konrad Sztyber's avatar Konrad Sztyber Committed by Tomasz Zawadzki
Browse files

nvme: execute hotplug monitor even if hotplug_fd < 0 



NVMe controllers can be marked as removed even if we cannot receive
uevents (e.g. by the VMD driver), so we should process them regardless
of hotplug_fd.

Signed-off-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Iaaf13a136929200e824f7a6dd3b5584998801630
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15547


Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarTom Nabarro <tom.nabarro@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 0a672ea9

lib/nvme/nvme_pcie.c

+4 −6
Original line number Diff line number Diff line
@@ -104,13 +104,11 @@ _nvme_pcie_hotplug_monitor(struct spdk_nvme_probe_ctx *probe_ctx) 
	struct spdk_nvme_ctrlr *ctrlr, *tmp;

	struct spdk_pci_event event;



	if (g_spdk_nvme_driver->hotplug_fd < 0) {

		return 0;

	}



	if (g_spdk_nvme_driver->hotplug_fd >= 0) {

		while (spdk_pci_get_event(g_spdk_nvme_driver->hotplug_fd, &event) > 0) {

			_nvme_pcie_event_process(&event, probe_ctx->cb_ctx);

		}

	}



	/* Initiate removal of physically hotremoved PCI controllers. Even after

	 * they're hotremoved from the system, SPDK might still report them via RPC.