Commit 71a1bbdd authored by Chunyang Hui's avatar Chunyang Hui Committed by Jim Harris
Browse files

bdev/opal: Add check for strdup 



Change-Id: Ic3005bc0b854ed9e5ff4a2288c3715d1e79b1fb4
Signed-off-by: default avatarChunyang Hui <chunyang.hui@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/472113


Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 173353ba

module/bdev/nvme/vbdev_opal.c

+10 −2
Original line number Diff line number Diff line
@@ -372,7 +372,11 @@ spdk_vbdev_opal_create(const char *nvme_ctrlr_name, uint32_t nsid, uint8_t locki 


	cfg = &opal_bdev->cfg;

	cfg->nvme_ctrlr_name = strdup(nvme_ctrlr_name);

	assert(cfg->nvme_ctrlr_name != NULL);

	if (!cfg->nvme_ctrlr_name) {

		SPDK_ERRLOG("allocation for nvme_ctrlr_name failed\n");

		free(opal_bdev);

		return -ENOMEM;

	}



	cfg->locking_range_id = locking_range_id;

	cfg->range_start = range_start;
@@ -427,7 +431,11 @@ spdk_vbdev_opal_create(const char *nvme_ctrlr_name, uint32_t nsid, uint8_t locki 
		}

		opal_part_base->num_of_part = 0;

		opal_part_base->nvme_ctrlr_name = strdup(cfg->nvme_ctrlr_name);

		assert(opal_part_base->nvme_ctrlr_name != NULL);

		if (opal_part_base->nvme_ctrlr_name == NULL) {

			vbdev_opal_free_bdev(opal_bdev);

			spdk_bdev_part_base_free(opal_part_base->part_base);

			return -ENOMEM;

		}



		cfg->opal_base = opal_part_base;

		TAILQ_INSERT_TAIL(&g_opal_base, opal_part_base, tailq);