Commit 7174280a authored by Jacek Kalwas's avatar Jacek Kalwas Committed by Tomasz Zawadzki
Browse files

test/nvmf: adjust sleep time for timeout test 



Test expected ctrlr to be deleted after 7s but it is on the edge.

With ctrlr loss timeout set to 5s and reconnect delay to 2s it takes 6s
to initiate delete of the controller. Yet another extra 1s comes from
the bdev_nvme_retry_ios poller which can be registered just before 6s
(ctrlr loss timeout expired).

Simplest fix for intermittent failure is to extend this time. Comment
above sleep already states 2s (so it is 6s due to SPDK algo and another
1s for retry, which allows to complete reqs and put last ctrlr
references ...and another 1s to improve test stability).

Fixes #3663.

Change-Id: I476a262e97e85336588d4a54ec01fa5abae0ab53
Signed-off-by: default avatarJacek Kalwas <jacek.kalwas@nutanix.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/25983


Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
Reviewed-by: default avatarKonrad Sztyber <ksztyber@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz@tzawadzki.com>
parent 8d960f1d

test/nvmf/host/timeout.sh

+1 −1
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ sleep 2 
[[ "$(get_bdev)" == "NVMe0n1" ]]



# wait for the ctrlr_loss_timeout_sec time 2 sec and check bdevs and controller are deleted

sleep 5

sleep 6

[[ "$(get_controller)" == "" ]]

[[ "$(get_bdev)" == "" ]]