Commit 70619839 authored by Jacek Kalwas's avatar Jacek Kalwas Committed by Tomasz Zawadzki
Browse files

nvme: simplify fail cond in nvme_tcp_qpair_process_completions 



Checking the previous qpair state is unnecessary, since a non-NULL
fabric poll status indicates that a fabric command was outstanding
and the qpair's state was CONNECTING.

Change-Id: I6ee16d75e8a8c78509876f58aa1d437541d6a059
Signed-off-by: default avatarJacek Kalwas <jacek.kalwas@nutanix.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/26478


Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz@tzawadzki.com>
Reviewed-by: default avatarBen Walker <ben@nvidia.com>
Reviewed-by: default avatarJim Harris <jim.harris@nvidia.com>
Community-CI: Mellanox Build Bot
parent 1221f34d

lib/nvme/nvme_tcp.c

+1 −3
Original line number Diff line number Diff line
@@ -2095,7 +2095,6 @@ static int 
nvme_tcp_qpair_process_completions(struct spdk_nvme_qpair *qpair, uint32_t max_completions)

{

	struct nvme_tcp_qpair *tqpair = nvme_tcp_qpair(qpair);

	enum nvme_qpair_state state_prev;

	uint32_t reaped;

	int rc;
@@ -2148,12 +2147,11 @@ nvme_tcp_qpair_process_completions(struct spdk_nvme_qpair *qpair, uint32_t max_c 


	return reaped;

fail:

	state_prev = nvme_qpair_get_state(qpair);

	qpair->transport_failure_reason = SPDK_NVME_QPAIR_FAILURE_UNKNOWN;

	nvme_ctrlr_disconnect_qpair(qpair);



	/* Needed to free the poll_status */

	if (state_prev == NVME_QPAIR_CONNECTING && qpair->fabric_poll_status != NULL) {

	if (qpair->fabric_poll_status != NULL) {

		nvme_tcp_ctrlr_connect_qpair_poll(qpair->ctrlr, qpair);

	}