Commit 6df9159a authored by Pierre Lestringant's avatar Pierre Lestringant Committed by Tomasz Zawadzki
Browse files

nvme: unlikely error paths in spdk_nvme_poll_group_process_completions 



Change-Id: Ic4b118c8d768e1bf4a373ae99d3a8f176b9391a7
Signed-off-by: default avatarPierre Lestringant <plestringant@kalrayinc.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/26851


Reviewed-by: default avatarJacek Kalwas <jacek.kalwas@nutanix.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarJim Harris <jim.harris@nvidia.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
parent ed10a067

lib/nvme/nvme_poll_group.c

+2 −2
Original line number Diff line number Diff line
@@ -365,7 +365,7 @@ spdk_nvme_poll_group_process_completions(struct spdk_nvme_poll_group *group, 
	struct spdk_nvme_transport_poll_group *tgroup;

	int64_t error_reason = 0, num_completions = 0;



	if (disconnected_qpair_cb == NULL) {

	if (spdk_unlikely(disconnected_qpair_cb == NULL)) {

		return -EINVAL;

	}
@@ -379,7 +379,7 @@ spdk_nvme_poll_group_process_completions(struct spdk_nvme_poll_group *group, 


		local_completions = nvme_transport_poll_group_process_completions(tgroup, completions_per_qpair,

				    disconnected_qpair_cb);

		if (local_completions < 0) {

		if (spdk_unlikely(local_completions < 0)) {

			if (!error_reason) {

				error_reason = local_completions;

			}