Commit 6d442665 authored by Karol Latecki's avatar Karol Latecki Committed by Darek Stojaczyk
Browse files

bdev/rpc: remove if checks for obligatory rpc arguments 



These arguments are obligatory and spdk_json_decode_object will
fail even before we reach the if block.

Change-Id: I3c17faf570aefc7d96d009a595cf3a76994977e7
Signed-off-by: default avatarKarol Latecki <karol.latecki@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/462043


Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 46ebf1b1

lib/bdev/rpc/bdev_rpc.c

+3 −14
Original line number Diff line number Diff line
@@ -390,8 +390,6 @@ spdk_rpc_set_bdev_qd_sampling_period(struct spdk_jsonrpc_request *request, 
	struct spdk_bdev *bdev;

	struct spdk_json_write_ctx *w;



	req.period = UINT64_MAX;



	if (spdk_json_decode_object(params, rpc_set_bdev_qd_sampling_period_decoders,

				    SPDK_COUNTOF(rpc_set_bdev_qd_sampling_period_decoders),

				    &req)) {
@@ -399,20 +397,11 @@ spdk_rpc_set_bdev_qd_sampling_period(struct spdk_jsonrpc_request *request, 
		goto invalid;

	}



	if (req.name) {

	bdev = spdk_bdev_get_by_name(req.name);

	if (bdev == NULL) {

		SPDK_ERRLOG("bdev '%s' does not exist\n", req.name);

		goto invalid;

	}

	} else {

		SPDK_ERRLOG("Missing name param\n");

		goto invalid;

	}



	if (req.period == UINT64_MAX) {

		SPDK_ERRLOG("Missing period param");

	}



	w = spdk_jsonrpc_begin_result(request);

	spdk_bdev_set_qd_sampling_period(bdev, req.period);