Commit 6d2989fd authored by Anil Veerabhadrappa's avatar Anil Veerabhadrappa Committed by Tomasz Zawadzki
Browse files

nvmf: optimize listen address parsing code 



Optimize code

Signed-off-by: default avatarAnil Veerabhadrappa <anil.veerabhadrappa@broadcom.com>
Change-Id: I2debb9ec8af04a13feedfe53f56a3e539d06caf5
Signed-off-by: default avatarAnil Veerabhadrappa <anil.veerabhadrappa@broadcom.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/471206


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarAlexey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 5e25bbdd

module/event/subsystems/nvmf/conf.c

+7 −8
Original line number Diff line number Diff line
@@ -290,6 +290,7 @@ spdk_nvmf_parse_subsystem(struct spdk_conf_section *sp) 
{

	const char *nqn, *mode;

	size_t i;

	int ret = -1;

	int lcore;

	bool allow_any_host;

	bool allow_any_listener = true;
@@ -459,19 +460,17 @@ spdk_nvmf_parse_subsystem(struct spdk_conf_section *sp) 


		if (trid.trtype == SPDK_NVME_TRANSPORT_RDMA ||

		    trid.trtype == SPDK_NVME_TRANSPORT_TCP) {

			if (spdk_nvmf_tgt_parse_listen_ip_addr(address_dup, &trid)) {

				free(address_dup);

				continue;

			}

			ret = spdk_nvmf_tgt_parse_listen_ip_addr(address_dup, &trid);

		} else if (trid.trtype == SPDK_NVME_TRANSPORT_FC) {

			if (spdk_nvmf_tgt_parse_listen_fc_addr(address_dup, &trid)) {

				free(address_dup);

				continue;

			}

			ret = spdk_nvmf_tgt_parse_listen_fc_addr(address_dup, &trid);

		}



		free(address_dup);



		if (ret) {

			continue;

		}



		spdk_nvmf_tgt_listen(g_spdk_nvmf_tgt, &trid, spdk_nvmf_tgt_listen_done, NULL);



		spdk_nvmf_subsystem_add_listener(subsystem, &trid);