Commit 6c07ca54 authored Mar 14, 2018 by Lance Hartmann Committed by Jim Harris Mar 15, 2018

iscsi: Handle spdk_get_pdu() failure in spdk_iscsi_op_nopout()



Prepares spdk_iscsi_op_nopout() to handle the case where
spdk_get_pdu() will return NULL in a future patch instead
of abort()'ing.

Change-Id: I6a0563c14a1bddf219dd12de67f83b18d6fd82f4
Signed-off-by: Lance Hartmann <lance.hartmann@oracle.com>
Reviewed-on: https://review.gerrithub.io/403874


Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

parent 7734777a

lib/iscsi/iscsi.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -3529,6 +3529,10 @@ spdk_iscsi_op_nopout(struct spdk_iscsi_conn conn, struct spdk_iscsi_pdu pdu)

		/* response PDU */
		rsp_pdu = spdk_get_pdu();
		if (rsp_pdu == NULL) {
		free(data);
		return SPDK_ISCSI_CONNECTION_FATAL;
		}
		rsph = (struct iscsi_bhs_nop_in *)&rsp_pdu->bhs;
		rsp_pdu->data = data;
		rsph->opcode = ISCSI_OP_NOPIN;