Commit 6b97cccf authored by Jim Harris's avatar Jim Harris Committed by Tomasz Zawadzki
Browse files

bdev, bdev_nvme: deprecate VTUNE support 



This VTune integration was added many years ago, but
hasn't been tested and to my knowledge is not being
used by anyone.  The statistics it enables are very
limited, specific to the bdev nvme module with no
insight into the rest of an SPDK application.

So deprecate this support now, we will remove it
immediately after the v23.01 release.

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: I5552d85084c350e9d0b2570946801acd65a89d64
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16294


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
parent 2aa7fa70

configure

+2 −1
Original line number Diff line number Diff line
@@ -91,7 +91,7 @@ function usage() { 
	echo " --without-shared          No path required."

	echo " --with-iscsi-initiator    Build with iscsi bdev module."

	echo " --without-iscsi-initiator No path required."

	echo " --with-vtune=DIR          Required to profile I/O under Intel VTune Amplifier XE."

	echo " --with-vtune=DIR          Required to profile I/O under Intel VTune Amplifier XE. (Deprecated)"

	echo " --without-vtune           example: /opt/intel/vtune_amplifier_xe_version"

	echo " --with-ocf[=DIR]          Build OCF library and bdev module."

	echo " --without-ocf             If argument is directory, interpret it as root of OCF repo"
@@ -765,6 +765,7 @@ else 
fi



if [ "${CONFIG[VTUNE]}" = "y" ]; then

	echo "WARNING: VTune support is deprecated."

	if [ -z "${CONFIG[VTUNE_DIR]}" ]; then

		echo "When VTune is enabled, you must specify the VTune directory using --with-vtune=path"

		exit 1

lib/bdev/bdev.c

+3 −0
Original line number Diff line number Diff line
@@ -64,6 +64,8 @@ int __itt_init_ittlib(const char *, __itt_group_id); 
SPDK_LOG_DEPRECATION_REGISTER(bdev_register_examine_thread,

			      "bdev register and examine on non-app thread", "SPDK 23.05", 0);



SPDK_LOG_DEPRECATION_REGISTER(vtune_support, "Intel(R) VTune integration", "SPDK 23.05", 0);



static const char *qos_rpc_type[] = {"rw_ios_per_sec",

				     "rw_mbytes_per_sec", "r_mbytes_per_sec", "w_mbytes_per_sec"

				    };
@@ -1682,6 +1684,7 @@ spdk_bdev_initialize(spdk_bdev_init_cb cb_fn, void *cb_arg) 
	}



#ifdef SPDK_CONFIG_VTUNE

	SPDK_LOG_DEPRECATED(vtune_support);

	g_bdev_mgr.domain = __itt_domain_create("spdk_bdev");

#endif