Commit 6aa6bfdd authored by Jim Harris's avatar Jim Harris Committed by Changpeng Liu
Browse files

nvmf: use DEBUGLOG for unsupported features and log pages 



We cannot control what the host may send to the target.
For example, we have empirical evidence that Windows
will send vendor-specific IDs for features and log pages
(when testing with the vfio-user target transport).

So let's change the ERRLOGs in these cases to DEBUGLOGs.

Fixes issues #2004, #2007, #2008.

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: I8d5b92fc5e33d698af246f2f1c34f7cf51e6488a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8487


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatar <dongx.yi@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
parent bd4363d3

lib/nvmf/ctrlr.c

+2 −2
Original line number Diff line number Diff line
@@ -2178,7 +2178,7 @@ nvmf_ctrlr_get_log_page(struct spdk_nvmf_request *req) 
	}



invalid_log_page:

	SPDK_ERRLOG("Unsupported Get Log Page 0x%02X\n", lid);

	SPDK_DEBUGLOG(nvmf, "Unsupported Get Log Page 0x%02X\n", lid);

	response->status.sct = SPDK_NVME_SCT_GENERIC;

	response->status.sc = SPDK_NVME_SC_INVALID_FIELD;

	return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE;
@@ -2696,7 +2696,7 @@ nvmf_ctrlr_get_features(struct spdk_nvmf_request *req) 
		case SPDK_NVME_FEAT_ASYNC_EVENT_CONFIGURATION:

			return get_features_generic(req, ctrlr->feat.async_event_configuration.raw);

		default:

			SPDK_ERRLOG("Get Features command with unsupported feature ID 0x%02x\n", feature);

			SPDK_DEBUGLOG(nvmf, "Get Features command with unsupported feature ID 0x%02x\n", feature);

			response->status.sc = SPDK_NVME_SC_INVALID_FIELD;

			return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE;

		}