Commit 6967fec6 authored by Alexey Marchuk's avatar Alexey Marchuk Committed by Tomasz Zawadzki
Browse files

nvmf/rdma: Submit recv to SRQ when AER is released 



Currently we don't resubmit receive request associated with AER
request to SRQ. This leads to reducing of SRQ elements and may
lead to non responsive NVMF target.

Fixes #1507

Change-Id: Ie96f8c4be0202ae973e561ebe5ea28688a6a3b72
Signed-off-by: default avatarAlexey Marchuk <alexeymar@mellanox.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3558


Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarMichael Haeuptle <michaelhaeuptle@gmail.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent 8e5d5b8f

lib/nvmf/rdma.c

+17 −0
Original line number Diff line number Diff line
@@ -3567,6 +3567,23 @@ nvmf_rdma_request_free(struct spdk_nvmf_request *req) 
	struct spdk_nvmf_rdma_request	*rdma_req = SPDK_CONTAINEROF(req, struct spdk_nvmf_rdma_request, req);

	struct spdk_nvmf_rdma_transport	*rtransport = SPDK_CONTAINEROF(req->qpair->transport,

			struct spdk_nvmf_rdma_transport, transport);

	struct spdk_nvmf_rdma_qpair *rqpair = SPDK_CONTAINEROF(rdma_req->req.qpair,

					      struct spdk_nvmf_rdma_qpair, qpair);



	/*

	 * AER requests are freed when a qpair is destroyed. The recv corresponding to that request

	 * needs to be returned to the shared receive queue or the poll group will eventually be

	 * starved of RECV structures.

	 */

	if (rqpair->srq && rdma_req->recv) {

		int rc;

		struct ibv_recv_wr *bad_recv_wr;



		rc = ibv_post_srq_recv(rqpair->srq, &rdma_req->recv->wr, &bad_recv_wr);

		if (rc) {

			SPDK_ERRLOG("Unable to re-post rx descriptor\n");

		}

	}



	_nvmf_rdma_request_free(rdma_req, rtransport);

	return 0;