Commit 67c53372 authored by Michal Berger's avatar Michal Berger Committed by Tomasz Zawadzki
Browse files

test/dd: Remove workaround for older Bash versions 



As per shfmt.md, we have been building centos7 with 4.4 Bash inside
so this workoarund is not needed anymore.

Change-Id: I7c2792184dd9a906eaeb078c6cbe9f4eeee9f0de
Signed-off-by: default avatarMichal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21019


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
parent d4d9a181

test/dd/common.sh

+5 −11
Original line number Diff line number Diff line
@@ -53,18 +53,12 @@ gen_conf() { 
	for ref_name in "${methods[@]}"; do

		method=${ref_name#*method_} method=${method%_*} params=()



		# FIXME: centos7's Bash got trapped in 2011:

		# local -n ref=$ref_name -> local: -n: invalid option

		# HACK: it with eval and partial refs instead.

		eval "local refs=(\${!${ref_name}[@]})"

		local param_ref



		for param in "${refs[@]}"; do

			param_ref="${ref_name}[$param]"

			if [[ ${!param_ref} =~ ^([0-9]+|true|false|\{.*\})$ ]]; then

				params+=("\"$param\": ${!param_ref}")

		local -n refs=$ref_name

		for param in "${!refs[@]}"; do

			if [[ ${refs["$param"]} =~ ^([0-9]+|true|false|\{.*\})$ ]]; then

				params+=("\"$param\": ${refs["$param"]}")

			else

				params+=("\"$param\": \"${!param_ref}\"")

				params+=("\"$param\": \"${refs["$param"]}\"")

			fi

		done