Commit 67befd47 authored by Jacek Kalwas's avatar Jacek Kalwas Committed by Tomasz Zawadzki
Browse files

nvmf: remove min number of admin queue entries from spec file 



It was probably miss-interpretation of description from discovery log
page which refers to min admin max sq size.

Signed-off-by: default avatarJacek Kalwas <jacek.kalwas@intel.com>
Change-Id: I575bf7fd6beb904b3a38a07616b76a34f8365643
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1222


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
parent daa8f941

include/spdk/nvmf_spec.h

+2 −3
Original line number Diff line number Diff line
@@ -46,9 +46,6 @@ 


#pragma pack(push, 1)



/* Minimum number of admin queue entries defined by NVMe over Fabrics spec */

#define SPDK_NVMF_MIN_ADMIN_QUEUE_ENTRIES	32



struct spdk_nvmf_capsule_cmd {

	uint8_t		opcode;

	uint8_t		reserved1;
@@ -391,6 +388,8 @@ union spdk_nvmf_transport_specific_address_subtype { 
SPDK_STATIC_ASSERT(sizeof(union spdk_nvmf_transport_specific_address_subtype) == 256,

		   "Incorrect size");



#define SPDK_NVMF_MIN_ADMIN_MAX_SQ_SIZE 32



/**

 * Discovery Log Page entry

 */

lib/nvmf/transport.c

+6 −0
Original line number Diff line number Diff line
@@ -120,6 +120,12 @@ spdk_nvmf_transport_create(const char *transport_name, struct spdk_nvmf_transpor 
		return NULL;

	}



	if (opts->max_aq_depth < SPDK_NVMF_MIN_ADMIN_MAX_SQ_SIZE) {

		SPDK_ERRLOG("max_aq_depth %u is less than minimum defined by NVMf spec, use min value\n",

			    opts->max_aq_depth);

		opts->max_aq_depth = SPDK_NVMF_MIN_ADMIN_MAX_SQ_SIZE;

	}



	transport = ops->create(opts);

	if (!transport) {

		SPDK_ERRLOG("Unable to create new transport of type %s\n", transport_name);