Commit 67794790 authored Jul 31, 2018 by Ben Walker Committed by Jim Harris Aug 01, 2018

nvmf: Simplify spdk_nvmf_qpair_disconnect



Asking which thread we're currently on is more expensive
than sending a message.

Change-Id: I9d9007c9f7f30e4cdd9a97de6bf7a10b0e2a0594
Signed-off-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.gerrithub.io/420933


Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>

parent 62209642

lib/nvmf/nvmf.c

+2 −6

Original line number	Diff line number	Diff line
		@@ -767,12 +767,8 @@ spdk_nvmf_qpair_disconnect(struct spdk_nvmf_qpair *qpair, nvmf_qpair_disconnect_
		qpair_ctx->cb_fn = cb_fn;
		qpair_ctx->thread = qpair->group->thread;
		qpair_ctx->ctx = ctx;
		if (qpair->group->thread == spdk_get_thread()) {
		_spdk_nvmf_qpair_deactivate(qpair_ctx);
		} else {
		/* Send a message to the thread that owns this qpair */
		spdk_thread_send_msg(qpair->group->thread, _spdk_nvmf_qpair_deactivate, qpair_ctx);
		}
		return 0;
		}