Commit 66d101ff authored Oct 14, 2017 by Dariusz Stojaczyk Committed by Daniel Verkamp Oct 16, 2017

rte_virtio: remove virtqueue_notify()



Simplified some code.

Change-Id: I9fc42da93a4c2df3714775d73508de118a5e6b1a
Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Reviewed-on: https://review.gerrithub.io/382618


Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>

parent 5b6e6788

lib/bdev/virtio/rte_virtio/virtio_queue.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -243,7 +243,7 @@ virtio_xmit_pkts(struct virtqueue vq, struct virtio_req req)
		vq_update_avail_idx(vq);

		if (spdk_unlikely(virtqueue_kick_prepare(vq))) {
		virtqueue_notify(vq);
		vtpci_ops(vdev)->notify_queue(vdev, vq);
		PMD_TX_LOG(DEBUG, "Notified backend after xmit");
		}

lib/bdev/virtio/rte_virtio/virtio_queue.h

+0 −11

Original line number	Diff line number	Diff line
		@@ -169,15 +169,4 @@ virtqueue_kick_prepare(struct virtqueue *vq)
		return !(vq->vq_ring.used->flags & VRING_USED_F_NO_NOTIFY);
		}

		static inline void
		virtqueue_notify(struct virtqueue *vq)
		{
		/*
		* Ensure updated avail->idx is visible to host.
		* For virtio on IA, the notificaiton is through io port operation
		* which is a serialization instruction itself.
		*/
		vtpci_ops(vq->vdev)->notify_queue(vq->vdev, vq);
		}

		#endif /* _VIRTQUEUE_H_ */