Commit 65b5866e authored by Anil Veerabhadrappa's avatar Anil Veerabhadrappa Committed by Jim Harris
Browse files

nvmf/fc: optimize code to access structure members only when needed 



   Reference the struct members only when it is necessary.

Signed-off-by: default avatarAnil Veerabhadrappa <anil.veerabhadrappa@broadcom.com>
Change-Id: I44208dfde20f74ab96e494445a464bf45f7ab408
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5070


Community-CI: Broadcom CI
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 33e1f4b0

lib/nvmf/fc.c

+4 −4
Original line number Diff line number Diff line
@@ -1431,9 +1431,7 @@ void 
_nvmf_fc_request_free(struct spdk_nvmf_fc_request *fc_req)

{

	struct spdk_nvmf_fc_hwqp *hwqp = fc_req->hwqp;

	struct spdk_nvmf_fc_poll_group *fgroup = hwqp->fgroup;

	struct spdk_nvmf_transport_poll_group *group = &fgroup->group;

	struct spdk_nvmf_transport *transport = group->transport;

	struct spdk_nvmf_transport_poll_group *group;



	if (!fc_req) {

		return;
@@ -1446,7 +1444,9 @@ _nvmf_fc_request_free(struct spdk_nvmf_fc_request *fc_req) 


	/* Release IO buffers */

	if (fc_req->req.data_from_pool) {

		spdk_nvmf_request_free_buffers(&fc_req->req, group, transport);

		group = &hwqp->fgroup->group;

		spdk_nvmf_request_free_buffers(&fc_req->req, group,

					       group->transport);

	}

	fc_req->req.data = NULL;

	fc_req->req.iovcnt  = 0;