Commit 64df311e authored by Jim Harris's avatar Jim Harris Committed by Tomasz Zawadzki
Browse files

nvme: add KEYED_DATA_BLOCK to sgl_types 



This SGL type was missed in the original commit
that added the pretty printing.

Fixes: 4d9ab1e9 ("nvme: pretty print dptr")

Reported-by: default avatarRamanjaneya Burugula <burugula@gmail.com>
Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: Ibc655db4e65009071f39f55f691c94a094cea0bc
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12705


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
parent 9b5dabff

lib/nvme/nvme_qpair.c

+1 −0
Original line number Diff line number Diff line
@@ -136,6 +136,7 @@ static const struct nvme_string sgl_type[] = { 
	{ SPDK_NVME_SGL_TYPE_BIT_BUCKET, "BIT BUCKET" },

	{ SPDK_NVME_SGL_TYPE_SEGMENT, "SEGMENT" },

	{ SPDK_NVME_SGL_TYPE_LAST_SEGMENT, "LAST SEGMENT" },

	{ SPDK_NVME_SGL_TYPE_KEYED_DATA_BLOCK, "KEYED DATA BLOCK" },

	{ SPDK_NVME_SGL_TYPE_TRANSPORT_DATA_BLOCK, "TRANSPORT DATA BLOCK" },

	{ SPDK_NVME_SGL_TYPE_VENDOR_SPECIFIC, "VENDOR SPECIFIC" },

	{ 0xFFFF, "RESERVED" }

test/unit/lib/nvme/nvme_qpair.c/nvme_qpair_ut.c

+1 −1
Original line number Diff line number Diff line
@@ -756,7 +756,7 @@ test_nvme_get_sgl_print_info(void) 
	cmd.dptr.sgl1.keyed.key = 0xababccdd;



	nvme_get_sgl(buf, NVME_CMD_DPTR_STR_SIZE, &cmd);

	CU_ASSERT(!strncmp(buf, "SGL RESERVED ADDRESS 0xdeadbeef len:0x1000 key:0xababccdd",

	CU_ASSERT(!strncmp(buf, "SGL KEYED DATA BLOCK ADDRESS 0xdeadbeef len:0x1000 key:0xababccdd",

			   NVME_CMD_DPTR_STR_SIZE));

}