Commit 64afb3c4 authored by Jim Harris's avatar Jim Harris
Browse files

bdev: use "size" argument for num_blocks 



Currently we are putting num_blocks in its own argument. Technically
this might be more correct since num_blocks is 64-bit and size
is 32-bit. num_blocks > 32-bit isn't a normal case so just truncate it
to simplify the output.

Signed-off-by: default avatarJim Harris <jim.harris@samsung.com>
Change-Id: I4dcf14ba1f595a84a52e758e9ec6eebeaef13a59
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22873


Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
parent 99e6c40e

lib/bdev/bdev.c

+3 −3
Original line number Diff line number Diff line
@@ -3554,9 +3554,10 @@ bdev_io_submit(struct spdk_bdev_io *bdev_io) 
	TAILQ_INSERT_TAIL(&ch->io_submitted, bdev_io, internal.ch_link);



	bdev_io->internal.submit_tsc = spdk_get_ticks();

	spdk_trace_record_tsc(bdev_io->internal.submit_tsc, TRACE_BDEV_IO_START, ch->trace_id, 0,

	spdk_trace_record_tsc(bdev_io->internal.submit_tsc, TRACE_BDEV_IO_START,

			      ch->trace_id, bdev_io->u.bdev.num_blocks,

			      (uintptr_t)bdev_io, (uint64_t)bdev_io->type, bdev_io->internal.caller_ctx,

			      bdev_io->u.bdev.offset_blocks, bdev_io->u.bdev.num_blocks);

			      bdev_io->u.bdev.offset_blocks);



	if (bdev_io->internal.split) {

		bdev_io_split(bdev_io);
@@ -10387,7 +10388,6 @@ SPDK_TRACE_REGISTER_FN(bdev_trace, "bdev", TRACE_GROUP_BDEV) 
				{ "type", SPDK_TRACE_ARG_TYPE_INT, 8 },

				{ "ctx", SPDK_TRACE_ARG_TYPE_PTR, 8 },

				{ "offset", SPDK_TRACE_ARG_TYPE_INT, 8 },

				{ "len", SPDK_TRACE_ARG_TYPE_INT, 8 }

			}

		},

		{