Commit 63d55304 authored Mar 24, 2020 by Anil Veerabhadrappa Committed by Tomasz Zawadzki Apr 02, 2020

nvmf/fc: Add FC listen addresses to target listeners

Add FC listen address to target listeners table before attaching the
same to the subsystem listener list. Without this fix, subsystem allow
any listener provision which is very important to FC-NVMe is broken.

Signed-off-by: Anil Veerabhadrappa <anil.veerabhadrappa@broadcom.com>
Change-Id: I06436c0a73e65cb5f7bb3280658fcf200b975989
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1443

Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>

parent 1c5444d6

lib/nvmf/fc.c

+8 −3

Original line number	Diff line number	Diff line
		@@ -3018,7 +3018,12 @@ nvmf_fc_adm_add_rem_nport_listener(struct spdk_nvmf_fc_nport *nport, bool add)
		spdk_nvmf_fc_create_trid(&ctx->trid,
		nport->fc_nodename.u.wwn,
		nport->fc_portname.u.wwn);
		if (spdk_nvmf_subsystem_pause(subsystem,

		if (spdk_nvmf_tgt_listen(subsystem->tgt, &ctx->trid)) {
		SPDK_ERRLOG("Failed to add transport address %s to tgt listeners\n",
		ctx->trid.traddr);
		free(ctx);
		} else if (spdk_nvmf_subsystem_pause(subsystem,
		nvmf_fc_adm_subsystem_paused_cb,
		ctx)) {
		SPDK_ERRLOG("Failed to pause subsystem: %s\n",