Commit 6394849a authored by Mateusz Kozlowski's avatar Mateusz Kozlowski Committed by Jim Harris
Browse files

lib/ftl: Fix memory leak found in context of ftl_mngt_superblock_init 



The data buf for FTL_LAYOUT_REGION_TYPE_SB_BASE MD is unnecesarily allocated, since
the MD mirror is using primary's data buf.

Change-Id: I2fac527cf14f6a06e4c40db7247aa9f94e2672c8
Signed-off-by: default avatarMateusz Kozlowski <mateusz.kozlowski@solidigm.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20860


Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Reviewed-by: default avatarBen Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 522a0c82

lib/ftl/ftl_layout.c

+2 −0
Original line number Diff line number Diff line
@@ -414,6 +414,8 @@ ftl_layout_setup_superblock(struct spdk_ftl_dev *dev) 
	assert(region->bdev_desc != NULL);

	assert(region->ioch != NULL);



	layout->region[FTL_LAYOUT_REGION_TYPE_SB].mirror_type = FTL_LAYOUT_REGION_TYPE_SB_BASE;



	region = &layout->region[FTL_LAYOUT_REGION_TYPE_SB_BASE];

	region->type = FTL_LAYOUT_REGION_TYPE_SB_BASE;

	region->mirror_type = FTL_LAYOUT_REGION_TYPE_INVALID;