Commit 637d0d0b authored by Michal Berger's avatar Michal Berger Committed by Konrad Sztyber
Browse files

scripts/rpc: Fix conserve_cpu arg in bdev_xnvme_create() 



Currently, there's no way to actually change this arg while calling
this particular rpc. So make sure it's possible, and keep it as an
optional arg with default still set to False (as per b99b00e5).

Change-Id: I889179bfa46a6261d2e30eeba4a5a14395e756a5
Signed-off-by: default avatarMichal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25287


Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: default avatarPawel Piatek <pawelx.piatek@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarJim Harris <jim.harris@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: default avatarKarl Bonde Torp <k.torp@samsung.com>
parent 1c2e5eda

python/spdk/rpc/bdev.py

+2 −3
Original line number Diff line number Diff line
@@ -541,7 +541,7 @@ def bdev_uring_delete(client, name): 
    return client.call('bdev_uring_delete', params)





def bdev_xnvme_create(client, filename, name, io_mechanism, conserve_cpu=None):

def bdev_xnvme_create(client, filename, name, io_mechanism, conserve_cpu):

    """Create a bdev with xNVMe backend.

    Args:

        filename: path to device or file (ex: /dev/nvme0n1)
@@ -555,7 +555,6 @@ def bdev_xnvme_create(client, filename, name, io_mechanism, conserve_cpu=None): 
    params['filename'] = filename

    params['name'] = name

    params['io_mechanism'] = io_mechanism

    if conserve_cpu is not None:

    params['conserve_cpu'] = conserve_cpu

    return client.call('bdev_xnvme_create', params)

scripts/rpc.py

+3 −2
Original line number Diff line number Diff line
@@ -578,13 +578,14 @@ if __name__ == "__main__": 
        print_json(rpc.bdev.bdev_xnvme_create(args.client,

                                              filename=args.filename,

                                              name=args.name,

                                              io_mechanism=args.io_mechanism))

                                              io_mechanism=args.io_mechanism,

                                              conserve_cpu=args.conserve_cpu))



    p = subparsers.add_parser('bdev_xnvme_create', help='Create a bdev with xNVMe backend')

    p.add_argument('filename', help='Path to device or file (ex: /dev/nvme0n1)')

    p.add_argument('name', help='name of xNVMe bdev to create')

    p.add_argument('io_mechanism', help='IO mechanism to use (ex: libaio, io_uring, io_uring_cmd, etc.)')

    p.add_argument('conserve_cpu', action='store_true', help='Whether or not to conserve CPU when polling')

    p.add_argument('-c', '--conserve-cpu', action='store_true', help='Whether or not to conserve CPU when polling')

    p.set_defaults(func=bdev_xnvme_create)



    def bdev_xnvme_delete(args):