Commit 630db8c2 authored by Jacek Kalwas's avatar Jacek Kalwas Committed by Tomasz Zawadzki
Browse files

nvmf: rm parse trtype in create transport rpc 



seems it is not required, string is used instead enum

Signed-off-by: default avatarJacek Kalwas <jacek.kalwas@intel.com>
Change-Id: Ic67af6cfa6f8e22a6593f904cd5b5c1b51cae6ec
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9623


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
parent a3d93c46

lib/nvmf/nvmf_rpc.c

+0 −9
Original line number Diff line number Diff line
@@ -1922,7 +1922,6 @@ rpc_nvmf_create_transport(struct spdk_jsonrpc_request *request, 
			  const struct spdk_json_val *params)

{

	struct nvmf_rpc_create_transport_ctx *ctx;

	enum spdk_nvme_transport_type trtype;

	struct spdk_nvmf_tgt *tgt;



	ctx = calloc(1, sizeof(*ctx));
@@ -1950,14 +1949,6 @@ rpc_nvmf_create_transport(struct spdk_jsonrpc_request *request, 
		return;

	}



	if (spdk_nvme_transport_id_parse_trtype(&trtype, ctx->trtype)) {

		SPDK_ERRLOG("Invalid transport type '%s'\n", ctx->trtype);

		spdk_jsonrpc_send_error_response_fmt(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,

						     "Invalid transport type '%s'", ctx->trtype);

		nvmf_rpc_create_transport_ctx_free(ctx);

		return;

	}



	/* Initialize all the transport options (based on transport type) and decode the

	 * parameters again to update any options passed in rpc create transport call.

	 */