Commit 6238e1a2 authored by Ziye Yang's avatar Ziye Yang Committed by Tomasz Zawadzki
Browse files

lib/iscsi: directly use task->scsi.offset in iscsi_send_datain 



For sending data in pdus, we can direclty use task->scsi.offset,
because task->scsi.offset is already set it before (in functions
iscsi_conn_handle_queued_datain_tasks). So we should not update
this offset in the task structure again.

Signed-off-by: default avatarZiye Yang <ziye.yang@intel.com>
Change-Id: I873a6f7fb174145fd90fe84a00a80a4de2d49161
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5753


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
parent 45744ace

lib/iscsi/iscsi.c

+1 −4
Original line number Diff line number Diff line
@@ -2987,11 +2987,8 @@ iscsi_send_datain(struct spdk_iscsi_conn *conn, 
	}

	DataSN++;



	if (task->parent) {

		offset += primary->scsi.data_transferred;

	}

	offset += task->scsi.offset;

	to_be32(&rsph->buffer_offset, (uint32_t)offset);

	task->scsi.offset = offset;



	if (F_bit && S_bit) {

		to_be32(&rsph->res_cnt, residual_len);