Commit 620e9a1e authored Mar 27, 2024 by Tomasz Zawadzki Committed by Jim Harris Apr 01, 2024

example/bdevperf: fix rw_percentage for reset flow



(b2cfb6b4)bdevperf: fix non expected reads for verify flow

Patch above added check for job type during I/O completion,
that catches unexpected read operations. This was done by
setting rw_percentage to 0.

That patch did not account for reset job type, which
shares the flow with verify and only adds resets.

Fix this by fallingthrough to verify in job config for
reset job.

Fixes #3320

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I4e449d533ea3ab2587653493953f0dea18e1c656
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22519


Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jacek Kalwas <jacek.kalwas@intel.com>

parent a60e1acc

examples/bdev/bdevperf/bdevperf.c

+4 −5

Original line number	Diff line number	Diff line
		@@ -1705,17 +1705,16 @@ job_init_rw(struct bdevperf_job *job, enum job_config_rw rw)
		job->is_random = true;
		job->seed = rand();
		break;
		case JOB_CONFIG_RW_RESET:
		/* Reset shares the flow with verify. */
		job->reset = true;
		/* fallthrough */
		case JOB_CONFIG_RW_VERIFY:
		job->verify = true;
		/* For verify flow read is done on write completion
		* callback only, rw_percentage shall not be used. */
		job->rw_percentage = 0;
		break;
		case JOB_CONFIG_RW_RESET:
		job->reset = true;
		job->verify = true;
		job->rw_percentage = 50;
		break;
		case JOB_CONFIG_RW_UNMAP:
		job->unmap = true;
		break;