Commit 62029730 authored by Jim Harris's avatar Jim Harris Committed by Tomasz Zawadzki
Browse files

bdev_nvme: change discovery_poller check to assert 



spdk_nvme_probe_poll_async() can only return 0 or -EAGAIN.
But the code currently indicates that other values might be
possible - so change the code to remove that confusion.

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: I8e7b2e1183f6650043dd751d610d434d626efa7e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15110


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
parent 7e17de3d

module/bdev/nvme/bdev_nvme.c

+2 −3
Original line number Diff line number Diff line
@@ -5307,13 +5307,12 @@ discovery_poller(void *arg) 
				assert(ctx->initializing);

				stop_discovery(ctx, NULL, ctx->cb_ctx);

			} else {

				assert(rc == 0);

				DISCOVERY_INFOLOG(ctx, "discovery ctrlr connected\n");

				ctx->rc = rc;

				if (rc == 0) {

				get_discovery_log_page(ctx);

			}

		}

		}

	} else {

		if (ctx->timeout_ticks != 0 && ctx->timeout_ticks < spdk_get_ticks()) {

			DISCOVERY_ERRLOG(ctx, "timed out while attaching NVM ctrlrs\n");