Commit 607d2226 authored by Kamil Godzwon's avatar Kamil Godzwon Committed by Tomasz Zawadzki
Browse files

scripts/nvmf_perf: raise an exception when subsystems var is empty 



If SPDK crashes and is not running, subsystems will not be
found on the target side. It may lead to exceptions in the
other code parts e.g ZeroDivisionError: division by zero

Signed-off-by: default avatarKamil Godzwon <kamilx.godzwon@intel.com>
Change-Id: Ia99ec2d14d773687410e970f2c72ab9868b410f1
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19702


Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKarol Latecki <karol.latecki@intel.com>
Reviewed-by: default avatarBen Walker <ben@nvidia.com>
Reviewed-by: default avatarJim Harris <jim.harris@gmail.com>
parent 6fb592fa

scripts/perf/nvmf/run_nvmf.py

+2 −0
Original line number Diff line number Diff line
@@ -814,6 +814,8 @@ class Initiator(Server): 


    def match_subsystems(self, target_subsystems):

        subsystems = [subsystem for subsystem in target_subsystems if subsystem[2] in self.target_nic_ips]

        if not subsystems:

            raise Exception("No matching subsystems found on target side!")

        subsystems.sort(key=lambda x: x[1])

        self.log.info("Found matching subsystems on target side:")

        for s in subsystems: