Commit 606c4a83 authored by Xin Yang's avatar Xin Yang Committed by Tomasz Zawadzki
Browse files

sma: raise an error if the device handle is invalid for DetachVolume() 



Throw a DeviceException to maintain consistency with the
implementation of other RPC interfaces.

Signed-off-by: default avatarXin Yang <Xin.Yang@arm.com>
Change-Id: I0eb7cfefbb6405da7c68f42a4a22c3016308023a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17300


Reviewed-by: default avatarZiye Yang <ziye.yang@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarYibo Cai <yibo.cai@arm.com>
Reviewed-by: default avatarArtek Koltun <artsiom.koltun@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent c5d2a852

python/spdk/sma/sma.py

+4 −3
Original line number Diff line number Diff line
@@ -141,7 +141,8 @@ class StorageManagementAgent(pb2_grpc.StorageManagementAgentServicer): 
        response = pb2.DetachVolumeResponse()

        try:

            device = self._find_device_by_handle(request.device_handle)

            if device is not None:

            if device is None:

                raise DeviceException(grpc.StatusCode.NOT_FOUND, 'Invalid device handle')

            device.detach_volume(request)

            self._volume_mgr.disconnect_volume(request.volume_id)

        except DeviceException as ex: