Commit 6005fdba authored by Jim Harris's avatar Jim Harris Committed by Darek Stojaczyk
Browse files

build: add missing xx_MODULES_LINKER_ARGS 



There were several applications that were missing
either SOCK_MODULES_LINKER_ARGS or COPY_MODULES_LINKER_ARGS.

For the ones missing SOCK_MODULES_LINKER_ARGS (fuse and rocksdb),
the nvme inititator with TCP transport would not have worked
at all.

Adding COPY_MODULES_LINKER_ARGS to the bdev fio plugin enables
ioat which isn't critical, but adding it makes it consistent
with other apps and will allow its Makefile to be simplified in
some future patches.

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: I0098350d75d27ad2b2d408221b727698f5e902e4

Reviewed-on: https://review.gerrithub.io/434260


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent 9a471061

examples/bdev/fio_plugin/Makefile

+1 −0
Original line number Diff line number Diff line
@@ -46,6 +46,7 @@ LDFLAGS += -shared -rdynamic 
SPDK_LIB_LIST += thread util bdev conf copy rpc jsonrpc json log sock trace



LIBS += $(BLOCKDEV_MODULES_LINKER_ARGS) $(SOCK_MODULES_LINKER_ARGS)

LIBS += $(COPY_MODULES_LINKER_ARGS)

LIBS += $(SPDK_LIB_LINKER_ARGS)



all: $(APP)

lib/rocksdb/spdk.rocksdb.mk

+1 −0
Original line number Diff line number Diff line
@@ -57,6 +57,7 @@ SPDK_LIB_LIST = event_bdev event_copy 
SPDK_LIB_LIST += bdev copy event util conf trace log jsonrpc json rpc sock thread



AM_LINK += $(COPY_MODULES_LINKER_ARGS) $(BLOCKDEV_MODULES_LINKER_ARGS)

AM_LINK += $(SOCK_MODULES_LINKER_ARGS)

AM_LINK += $(SPDK_LIB_LINKER_ARGS) $(ENV_LINKER_ARGS)

AM_LINK += $(SYS_LIBS)

test/blobfs/fuse/Makefile

+1 −1
Original line number Diff line number Diff line
@@ -44,7 +44,7 @@ SPDK_LIB_LIST = event_bdev event_copy 
SPDK_LIB_LIST += bdev copy event thread util conf trace \

		log jsonrpc json rpc sock



LIBS += $(COPY_MODULES_LINKER_ARGS) $(BLOCKDEV_MODULES_LINKER_ARGS)

LIBS += $(COPY_MODULES_LINKER_ARGS) $(BLOCKDEV_MODULES_LINKER_ARGS) $(SOCK_MODULES_LINKER_ARGS)

LIBS += $(SPDK_LIB_LINKER_ARGS)

LIBS+= -L/usr/local/lib -lfuse3