Commit 5f5c5275 authored by Krzysztof Sprzaczkowski's avatar Krzysztof Sprzaczkowski Committed by Tomasz Zawadzki
Browse files

lib/event: Set/clear log flag RPC doesn't return an error for invalid flag name. 



Return an error if invalid flag name is provided for RPC
log_set_flag/log_clear operations.

Part of issue #3365

Change-Id: I53e323f75103293bf0b9adc809aefa518fb6285c
Signed-off-by: default avatarKrzysztof Sprzaczkowski <krzysztof.sprzaczkowski@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23221


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
parent 5b4cf6db

lib/event/log_rpc.c

+14 −2
Original line number Diff line number Diff line
@@ -212,7 +212,13 @@ rpc_log_set_flag(struct spdk_jsonrpc_request *request, 
		goto end;

	}



	spdk_log_set_flag(req.flag);

	if (spdk_log_set_flag(req.flag) != 0) {

		SPDK_DEBUGLOG(log_rpc, "tried to set invalid log flag\n");

		spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,

						 "invalid log flag");

		goto end;

	}



	spdk_jsonrpc_send_bool_response(request, true);

end:

	free_rpc_log_flag(&req);
@@ -240,7 +246,13 @@ rpc_log_clear_flag(struct spdk_jsonrpc_request *request, 
		goto end;

	}



	spdk_log_clear_flag(req.flag);

	if (spdk_log_clear_flag(req.flag) != 0) {

		SPDK_DEBUGLOG(log_rpc, "tried to clear invalid log flag\n");

		spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,

						 "invalid log flag");

		goto end;

	}



	spdk_jsonrpc_send_bool_response(request, true);

end:

	free_rpc_log_flag(&req);