Commit 5eb33f0a authored by Daniel Verkamp's avatar Daniel Verkamp Committed by Jim Harris
Browse files

nbd: return path to /dev/nbd* in start_nbd_disk 



This will allow us to make the start_nbd_disk method choose an available
/dev/nbd* node automatically in an upcoming commit.

Change-Id: I3c6eb67e7e0c513212eba17139fd0cc96bf9b6dd
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/413847


Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent 8b158aaa

CHANGELOG.md

+5 −0
Original line number Diff line number Diff line
@@ -2,6 +2,11 @@ 


## v18.07: (Upcoming Release)



### RPC



The `start_nbd_disk` RPC method now returns the path to the kernel NBD device node

rather than always returning `true`.



### Bdev



The spdk_bdev_get_io_stat() function now returns cumulative totals instead of resetting

lib/nbd/nbd_rpc.c

+3 −3
Original line number Diff line number Diff line
@@ -88,15 +88,15 @@ spdk_rpc_start_nbd_disk(struct spdk_jsonrpc_request *request, 
		goto invalid;

	}



	free_rpc_start_nbd_disk(&req);



	w = spdk_jsonrpc_begin_result(request);

	if (w == NULL) {

		free_rpc_start_nbd_disk(&req);

		return;

	}



	spdk_json_write_bool(w, true);

	spdk_json_write_string(w, req.nbd_device);

	spdk_jsonrpc_end_result(request, w);

	free_rpc_start_nbd_disk(&req);

	return;



invalid:

scripts/rpc.py

+3 −3
Original line number Diff line number Diff line
@@ -764,9 +764,9 @@ if __name__ == "__main__": 
    # nbd

    @call_cmd

    def start_nbd_disk(args):

        rpc.nbd.start_nbd_disk(args.client,

        print(rpc.nbd.start_nbd_disk(args.client,

                                     bdev_name=args.bdev_name,

                               nbd_device=args.nbd_device)

                                     nbd_device=args.nbd_device))



    p = subparsers.add_parser('start_nbd_disk', help='Export a bdev as a nbd disk')

    p.add_argument('bdev_name', help='Blockdev name to be exported. Example: Malloc0.')