Commit 5db859da authored by Krzysztof Karas's avatar Krzysztof Karas Committed by Tomasz Zawadzki
Browse files

apps: set NULL as RPC address in some apps 



Set opts.rpc_addr to NULL in SPDK applications that usually do not
benefit from starting RPC interface. These include programs in app,
examples and test directories.

Some of the tests now require that we explicitly set RPC address,
because some apps no longer use the default SPDK address.

Change-Id: I417a3a756581f44c711257e6d2408d933b40386a
Signed-off-by: default avatarKrzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22634


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
parent 2f3ac73d

app/spdk_dd/spdk_dd.c

+1 −0
Original line number Diff line number Diff line
@@ -1474,6 +1474,7 @@ main(int argc, char **argv) 
	opts.name = "spdk_dd";

	opts.reactor_mask = "0x1";

	opts.shutdown_cb = dd_finish;

	opts.rpc_addr = NULL;

	rc = spdk_app_parse_args(argc, argv, &opts, "", g_cmdline_opts, parse_args, usage);

	if (rc == SPDK_APP_PARSE_ARGS_FAIL) {

		SPDK_ERRLOG("Invalid arguments\n");

examples/accel/perf/accel_perf.c

+1 −0
Original line number Diff line number Diff line
@@ -1345,6 +1345,7 @@ main(int argc, char **argv) 
	g_opts.name = "accel_perf";

	g_opts.reactor_mask = "0x1";

	g_opts.shutdown_cb = shutdown_cb;

	g_opts.rpc_addr = NULL;



	rc = spdk_app_parse_args(argc, argv, &g_opts, "a:C:o:q:t:yw:M:P:f:T:l:S:x:", NULL,

				 parse_args, usage);

examples/bdev/hello_world/hello_bdev.c

+1 −0
Original line number Diff line number Diff line
@@ -286,6 +286,7 @@ main(int argc, char **argv) 
	/* Set default values in opts structure. */

	spdk_app_opts_init(&opts, sizeof(opts));

	opts.name = "hello_bdev";

	opts.rpc_addr = NULL;



	/*

	 * Parse built-in SPDK command line parameters as well

examples/blob/cli/blobcli.c

+1 −0
Original line number Diff line number Diff line
@@ -1598,6 +1598,7 @@ main(int argc, char **argv) 
	spdk_app_opts_init(&opts, sizeof(opts));

	opts.name = "blobcli";

	opts.json_config_file = cli_context->config_file;

	opts.rpc_addr = NULL;



	cli_context->app_started = true;

	rc = spdk_app_start(&opts, cli_start, cli_context);

examples/blob/hello_world/hello_blob.c

+1 −1
Original line number Diff line number Diff line
@@ -433,7 +433,7 @@ main(int argc, char **argv) 
	 */

	opts.name = "hello_blob";

	opts.json_config_file = argv[1];



	opts.rpc_addr = NULL;



	/*

	 * Now we'll allocate and initialize the blobstore itself. We