Commit 5db247ab authored Mar 17, 2020 by Darek Stojaczyk Committed by Tomasz Zawadzki Apr 06, 2020

test/spdkcli/tcp: don't override the ERR trap



That test used to call an inexistent function in its
ERR trap. That's for one. Second, none of the SPDK tests
should set the ERR trap themselves - it's set once in
autotest_common.sh and prints the backtrace. What test
scripts should do is setting SIGINT/EXIT traps - fix it now.

Change-Id: I46c82651be78eeaec16ac52396c5e80a0405e5ff
Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1331


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Michal Berger <michalx.berger@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

parent df9660df

test/spdkcli/tcp.sh

+2 −1

Original line number	Diff line number	Diff line
		@@ -46,7 +46,7 @@ function waitfortcplisten() {
		IP_ADDRESS="127.0.0.1"
		PORT="9998"

		trap 'on_error_exit;' ERR
		trap 'killprocess $spdk_tgt_pid; exit 1' SIGINT SIGTERM EXIT

		timing_enter run_spdk_tgt_tcp
		$rootdir/app/spdk_tgt/spdk_tgt -m 0x3 -p 0 -s 2048 -r $IP_ADDRESS:$PORT &
		@@ -57,4 +57,5 @@ waitfortcplisten $spdk_tgt_pid $IP_ADDRESS $PORT

		timing_exit run_spdk_tgt_tcp

		trap - SIGINT SIGTERM EXIT
		killprocess $spdk_tgt_pid